Doc work#170
Conversation
vinniefalco
requested review from
ashtum and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR refactors buffer operation function names in the codebase to use more descriptive and consistent naming. The changes replace older function names with more explicit alternatives that better convey their purpose.
- Replaces
buffers::trim_frontwithbuffers::remove_prefixthroughout the codebase - Replaces
buffers::keep_frontwithbuffers::keep_prefixfor consistency - Replaces
buffers::trim_backwithbuffers::remove_suffixfor symmetry - Updates
detail::prefixcalls to usebuffers::prefixfor consistency - Refactors helper functions in
buffer_utils.hppto improve implementation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/source.cpp | Updates buffer trimming call to use new function name |
| test/unit/serializer.cpp | Updates buffer operations to use new function names |
| test/unit/compression.cpp | Updates multiple buffer trimming calls throughout compression tests |
| src/serializer.cpp | Updates buffer operations in serializer implementation |
| src/parser.cpp | Updates prefix operations to use buffers namespace |
| src/detail/filter.cpp | Updates buffer trimming operations |
| src/detail/buffer_utils.hpp | Refactors prefix function removal and make_span implementation |
| src/detail/array_of_const_buffers.cpp | Updates buffer trimming call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vinniefalco
force-pushed
the
develop
branch
from
2bca25a to
13a5a52
Compare
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
3 similar comments
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
vinniefalco
force-pushed
the
develop
branch
from
dcf7962 to
154c38c
Compare
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #170 +/- ##
========================================
Coverage 92.53% 92.53%
========================================
Files 81 81
Lines 5061 5061
========================================
Hits 4683 4683
Misses 378 378 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
2 similar comments
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
vinniefalco
force-pushed
the
develop
branch
from
ae434d7 to
9847f20
Compare
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
3 similar comments
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
GCOVR code coverage report https://170.http-proto.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://170.http-proto.prtest.cppalliance.org/index.html |
vinniefalco
force-pushed
the
develop
branch
from
a9e900a to
06502c5
Compare
No description provided.